Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update To React-Native 0.57 #988

Closed
keshamtravels opened this issue Oct 6, 2018 · 12 comments
Closed

Update To React-Native 0.57 #988

keshamtravels opened this issue Oct 6, 2018 · 12 comments
Labels

Comments

@keshamtravels
Copy link

Please update this project to use react-native 0.57 so that the slow typing problems goes away on android.

@jackkav
Copy link

jackkav commented Oct 10, 2018

package-lock.json also needs to be regenerated to support 0.56+ because it still contains reference to
react-native-invertible-scroll-view which has a babel 7 issue. However it's no longer a dependency. expo/react-native-invertible-scroll-view#55

@shaheem-khanzada
Copy link

yes Update To React-Native 0.57 there are a lot of issues with flatList please update to 0.57

@yurykorzun
Copy link

You can try to reference my fork of the gifted chat here https://github.com/Flyclops/react-native-gifted-chat
I updated it to the most recent RN release.

@shaheem-khanzada
Copy link

@yurykorzun in this fork is flatList working fast?

@yurykorzun
Copy link

@yurykorzun in this fork is flatList working fast?

I am not 100% sure, but it works well for me.

@shaheem-khanzada
Copy link

shaheem-khanzada commented Oct 19, 2018 via email

@yurykorzun
Copy link

can u send mein code of how you are passing data to flatList

On Fri, Oct 19, 2018, 8:15 PM Yury Korzun @.***> wrote: @yurykorzun https://github.com/yurykorzun in this fork is flatList working fast? I am not 100% sure, but it works well for me. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#988 (comment)>, or mute the thread https://github.com/notifications/unsubscribe-auth/Aj4MU08Fvy9DFCwIWRJ9O0wdI8WTrUfjks5umeyrgaJpZM4XLg5I .

If you're asking about the gifted chat, I just set the messages prop and it forwards them to a FlatList. You can take a look at a MessageContainer,js

@sibelius
Copy link
Collaborator

can somebody send a pull request fixing this?

@Faolain
Copy link
Contributor

Faolain commented Dec 8, 2018

@yurykorzun can you please open a PR with the update? It would be greatly appreciated by the community :)

@stale
Copy link

stale bot commented Feb 12, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Feb 12, 2019
@Faolain
Copy link
Contributor

Faolain commented Feb 12, 2019

@yurykorzun were you able to get this working? If so can you please submit a PR?

@stale stale bot removed the wontfix label Feb 12, 2019
@stale
Copy link

stale bot commented Apr 13, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants