Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and Fix Slack Example onLongPress() #1143

Merged
merged 5 commits into from Feb 18, 2019

Conversation

Projects
None yet
2 participants
@thedmeyer
Copy link
Contributor

thedmeyer commented Feb 18, 2019

This PR fixes the Slack Example by updating onLongPress() in SlackBubble.js. The prior version was missing this.props.currentMessage for custom ActionSheets.

thedmeyer added some commits Jun 6, 2018

🐛 fixed onLongPress()
Prior version was missing this.props.currentMessage
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 18, 2019

Codecov Report

Merging #1143 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1143   +/-   ##
=======================================
  Coverage   41.03%   41.03%           
=======================================
  Files          21       21           
  Lines         524      524           
  Branches      117      117           
=======================================
  Hits          215      215           
  Misses        233      233           
  Partials       76       76

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c0b71a...98038cc. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 18, 2019

Codecov Report

Merging #1143 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1143   +/-   ##
=======================================
  Coverage   41.03%   41.03%           
=======================================
  Files          21       21           
  Lines         524      524           
  Branches      117      117           
=======================================
  Hits          215      215           
  Misses        233      233           
  Partials       76       76

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c0b71a...98038cc. Read the comment docs.

@xcarpentier xcarpentier merged commit 08f94d9 into FaridSafi:master Feb 18, 2019

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/project 41.03% remains the same compared to 5c0b71a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.