-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The future of GiftedChat 🎉 #1775
Conversation
f61aadd
to
5f36fc4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done
@xcarpentier would be great if you merge this PR, So we can continue with migration to functional components based on this. My idea is migrate the current user into context API you built so, we avoid to pass user prop around the tree. |
Hi! |
Hi |
@xcarpentier What did you say is necessary in order to merge this PR? |
3d82ace
to
e824e56
Compare
Please read the comment here |
@xcarpentier |
It’s not the structural kind of improvement I suggest for this PR. But I already think about GiftedChat components rendering and customization by a splitting it into small independent parts; with monorepo technic (lerna+workspace). That will mean a core and plugin small components into it like message video, audio, etc. Also I would like use build tool like tsdx for this project. |
3c6046d
to
c814443
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Clipboard is being imported from
react-native-gifted-chat/src/Bubble.tsx Lines 3 to 12 in 6d93f4a
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
If maintainer role can be given, alongside access to npm publishing, then progress can be made. |
I was looking at merging this PR, however at two years old, this rewrite will likely need additional changes. |
With some minor changes (mostly test & lint fixes), I pushed the branch to npm with the I'll be taking whatever feedback is posted here, along with what I find during testing to decide the path forward with this branch. |
In case anyone wanted to know my thinking
I'll likely action this in the next 24 hours or so, to allow time for challenges. |
@Johan-dutoit Thank you for your work on this! I’ll be trying it out soon for an app I’m building. |
Hah I'd love to take the credit @jamonholmgren, but I'm simply carrying @xcarpentier's work over the line. |
Carrying the work also worth the credits 👌 |
@xcarpentier |
Hi I think we should give a try to https://github.com/shopify/flash-list |
Roadmap
react-native-testing-library
defaultProps
into FC paramsconst fn = ({ something = 42 }: Props) => { // ... }
IMessage
using TypeScript features like tag literals to determine type of message (ie. text, video, audio, image, system and also status: 'sent' | 'received' | 'read', ...)Reviewers
Please I need to have some reviewers. 🙏