Fix scroll to bottom for screen readers #2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlapstra
changed the title
|
Sorry, but this issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. BTW Thank you for your contributions 😀 !!! |
|
So no updates on this one, right? |
|
If you're able to resolve the conflicts, then this can be merged in. |
… into fix-scroll-to-bottom-for-accessibility
|
@Johan-dutoit Sorry about that! Did not get a notification. This PR should be good to go now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scroll To Bottom Fix for Screen Readers
Explanation
While debugging I came across : This stack overflow question with the answer being to swap the components order.
Before
Result
This fixes VoiceOver for iOS users and TalkBack for Android users, such that they can successfully tap the scroll to bottom button when it overlaps other content, and be taken to the bottom of the message list.