(fix) Apply bottomOffset when keyboard is shown #2361
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying the
bottomOffset
prop was inadvertently removed in the PR to remove the react-safe-area-context dependency #2353 ThebottomOffset
props is often used when using React Navigation tabs for iOS to remove the gap created between the input/chat and keyboard. This PR restores the previous functionality of thebottomOffset
prop.Prior to this PR the
bottomOffset
prop was always applied when theonKeyboardWillShow
event was fired. This happened regardless if gifted chat was wrapped in a safe area or not.react-native-gifted-chat/src/GiftedChat.tsx
Line 638 in 75e75f0
react-native-gifted-chat/src/GiftedChat.tsx
Lines 597 to 599 in 75e75f0
I've reviewed this with the PR author amerikan (Thanks again for getting rid of this dependency!), and we both agree that this PR would resolve & restore the previous behavior.