Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

28 July Updates #364

Merged
merged 16 commits into from
Jul 28, 2017
Merged

28 July Updates #364

merged 16 commits into from
Jul 28, 2017

Conversation

RickCarlino
Copy link
Contributor

What's New?

  • Reject CI build if type checking fails.
  • Fix bug where FarmEvent<Regimen> would not render if start time was in the past, but work was still pending.
  • Render "" instead of -1 when coords are unknown.
  • seeds.rb updates
  • Don't render calendar if executable_type is Regimen- calculate it using regimen_items at runtime instead.
  • Start using ApplicationRecord instead of ActiveRecord::Base (relic from Rails v3 days)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 21.334% when pulling ae3b515 on RickCarlino:master into 5816daa on FarmBot:master.

@codecov
Copy link

codecov bot commented Jul 28, 2017

Codecov Report

Merging #364 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #364      +/-   ##
==========================================
+ Coverage   95.85%   95.86%   +0.01%     
==========================================
  Files         125      125              
  Lines        1880     1885       +5     
==========================================
+ Hits         1802     1807       +5     
  Misses         78       78
Impacted Files Coverage Δ
app/models/log.rb 100% <100%> (ø) ⬆️
app/models/device.rb 95% <100%> (ø) ⬆️
app/models/user.rb 100% <100%> (ø) ⬆️
app/models/farm_event.rb 100% <100%> (ø) ⬆️
app/models/regimen.rb 100% <100%> (ø) ⬆️
app/models/sequence_dependency.rb 100% <100%> (ø) ⬆️
app/serializers/farm_event_serializer.rb 100% <100%> (ø) ⬆️
app/models/generic_pointer.rb 100% <100%> (ø) ⬆️
app/models/regimen_item.rb 100% <100%> (ø) ⬆️
app/models/peripheral.rb 100% <100%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5816daa...c5fb3d4. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 21.355% when pulling 9cb7822 on RickCarlino:master into 5816daa on FarmBot:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 21.355% when pulling 9cb7822 on RickCarlino:master into 5816daa on FarmBot:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 21.376% when pulling b2dd582 on RickCarlino:master into 5816daa on FarmBot:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 21.429% when pulling 28debea on RickCarlino:master into 5816daa on FarmBot:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 21.617% when pulling 1af81cf on RickCarlino:master into 5816daa on FarmBot:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 21.617% when pulling c5fb3d4 on RickCarlino:master into 5816daa on FarmBot:master.

@RickCarlino RickCarlino merged commit 6729734 into FarmBot:master Jul 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants