Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there need for subscription based status updates from the device? #13

Closed
TimEvWw opened this issue Jun 20, 2014 · 6 comments
Closed
Labels

Comments

@TimEvWw
Copy link
Contributor

TimEvWw commented Jun 20, 2014

No description provided.

@roryaronson
Copy link
Member

What do you mean by subscription based? Would any of the following examples be considered subscription based? If not, what would be?

  • Device sends update every day at 3pm and the web-app "subscribes" to these updates
  • Device sends update with each completed command and the database subscribes to these updates to maintain synchronization
  • Device sends update every time there is an error, the web app subscribes to this and sends an email to the user with each update

@TimEvWw
Copy link
Contributor Author

TimEvWw commented Jun 20, 2014

When you connect with the site, you request the status from the bot to put
it on screen. Does the device has to send the same message every x seconds
so the site can display the latest status?? (moving now, next command
scheduled at ...)

On Fri, Jun 20, 2014 at 10:12 AM, Rory Aronson notifications@github.com
wrote:

What do you mean by subscription based? Would any of the following
examples be considered subscription based? If not, what would be?

  • Device sends update every day at 3pm and the web-app "subscribes" to
    these updates
  • Device sends update with each completed command and the database
    subscribes to these updates to maintain synchronization
  • Device sends update every time there is an error, the web app
    subscribes to this and sends an email to the user with each update


Reply to this email directly or view it on GitHub
#13 (comment)
.

@RickCarlino
Copy link
Contributor

I would like this feature. It would be nice to have for interacting with the UI layer.

@roryaronson
Copy link
Member

I agree with Rick, it would be nice to see a console of everything happening on the device in near real time

@TimEvWw
Copy link
Contributor Author

TimEvWw commented Jun 20, 2014

Now, what does the protocol looks like?

I was thinking for now of sending a message_type "read_status_subscription"
with parameter keep_alive = 15 minutes and period = 5 seconds. The status
message can be extended with a value subscription_timeout that is set to
true in the last minute so the site can send a new subscription to the bot.
This way the bot doesn't keep sending messages forever, only when it's
needed. There are probably better way but I can't think of them right now.

On Fri, Jun 20, 2014 at 8:08 PM, Rory Aronson notifications@github.com
wrote:

I agree with Rick, it would be nice to see a console of everything
happening on the device in near real time


Reply to this email directly or view it on GitHub
#13 (comment)
.

@RickCarlino
Copy link
Contributor

I think this feature has been implemented. Closing this issue.

ConnorRigby added a commit that referenced this issue Feb 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants