Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded dependencies #35

Merged
merged 2 commits into from
Oct 14, 2023

Conversation

thcrt
Copy link
Contributor

@thcrt thcrt commented Aug 30, 2023

I'm resubmitting #33 from a branch with only the two pertinent commits, so as to avoid dragging upstream along with any further changes until they're ready.

I plan to actively maintain my fork, Hetzname, going forward, since it's useful and important to me. Of course, I'll push changes upstream, which you are welcome to accept or deny as you wish.

I'd also be happy to maintain this upstream repo if you'd have me :^)


  • Remove awk as a dependency by using grep and tail.
  • Remove dig as a dependency by using curl1.
  • Remove bash as a dependency by using sh2.

These changes make use of the tool substantially easier on OpenWRT routers, where storage space is often at a premium and thus unneeded dependencies are sub-optimal.

Footnotes

  1. And use Hetzner's own external IP detector

  2. On OpenWRT routers, and perhaps other notable systems, this is a symlink to ash which works just as well. bash is not pre-installed on such devices.

@FarrowStrange FarrowStrange merged commit ccda493 into FarrowStrange:master Oct 14, 2023
@FarrowStrange
Copy link
Owner

Hey @thcrt
please excuse the late reply. Thanks for this great change so that the project can be used on more systems.

Since my resources are unfortunately very limited I would be very happy about a collaboration to keep the project active and up to date.

@thcrt
Copy link
Contributor Author

thcrt commented Dec 11, 2023

@FarrowStrange If you'd like, you could add me as a collaborator/maintainer? Then I can review issues/PRs/etc :)

@thcrt thcrt deleted the patch-remove-dependencies branch December 13, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants