Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt6: Build with mingw as well in CI to avoid accidentally breaking mingw build #1012

Merged
merged 8 commits into from
Aug 23, 2023

Conversation

csett86
Copy link
Collaborator

@csett86 csett86 commented Aug 10, 2023

ci: We dont ship the mingw build, but we want to make sure that it continues to build and not accidentally break it.

@csett86 csett86 marked this pull request as draft August 10, 2023 20:14
@ghost
Copy link

ghost commented Aug 10, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

…ngw build

We dont ship the mingw build, but we want to make sure that it continues to build
and not accidentally break it.
@FashionFreedom FashionFreedom deleted a comment from changelogg bot Aug 17, 2023
@csett86 csett86 marked this pull request as ready for review August 17, 2023 17:37
detected when building with mingw
otherwise compilation fails with oom
we dont release the mingw builds, so no need to sign them
@slspencer slspencer merged commit fd28da0 into qt6 Aug 23, 2023
9 of 10 checks passed
@slspencer slspencer deleted the qt6-ci-mingw branch August 23, 2023 07:23
@slspencer slspencer restored the qt6-ci-mingw branch August 23, 2023 07:29
@csett86 csett86 deleted the qt6-ci-mingw branch August 29, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants