Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove vanished translation strings from ts files #1013

Merged
merged 1 commit into from
Aug 12, 2023

Conversation

csett86
Copy link
Collaborator

@csett86 csett86 commented Aug 12, 2023

Now make lupdate adds new and removes vanished translation strings

Now make lupdate adds new and removes vanished translation strings
@what-the-diff
Copy link

what-the-diff bot commented Aug 12, 2023

PR Summary 🎉

Enhancement to the Updating Process

Changes made to the Seamly2D.pro file offer an improved process for updating items in the software. The team added the -noobsolete option to the lupdate command. This option makes the update process cleaner by ensuring that any unused elements are not unnecessarily involved. The beneficial impact of this improved command is now clearly seen in both translations.pro and measurements.pro files. 🚀😊

You guys are doing such an amazing job simplifying the process here. Keep up the neat work! ❤️ 👏

@ghost
Copy link

ghost commented Aug 12, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@csett86 csett86 requested a review from DSCaskey August 12, 2023 13:41
@DSCaskey
Copy link
Contributor

Looks good to me. Thank you @csett86

@csett86 csett86 merged commit 7669662 into develop Aug 12, 2023
10 checks passed
@csett86 csett86 deleted the lupdate-remove-vanished branch August 12, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants