Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: excessive logging #1025

Merged
merged 1 commit into from
Sep 21, 2023
Merged

fix: excessive logging #1025

merged 1 commit into from
Sep 21, 2023

Conversation

DSCaskey
Copy link
Contributor

@DSCaskey DSCaskey commented Sep 19, 2023 •
edited

This fixes the excessive file logging in release mode.

  • Adds a CONFIG define to only output qDebug() or qCDebug() messages in debug mode.
  • Replaces some qDebug() messages with qInfo() or qWarning() messages in order to control which messages we want to output to the log file, while allowing all messages to output in debug mode.
  • Refactors some symbols named "e" with "event" or "error".
  • Updates the Copyright notices in affected files.

Fixes issue #1024

@DSCaskey
fix excessive logging
e32db77 
This fixes the excessive file logging, replaces the  name "e" with event or error, and updates the Copyright notices.
@DSCaskey DSCaskey added the bug label Sep 19, 2023
@DSCaskey DSCaskey self-assigned this Sep 19, 2023
@ghost
Copy link

ghost commented Sep 19, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@csett86 csett86 linked an issue Sep 19, 2023 that may be closed by this pull request
BUG: App is excessively logging debug() messages #1024
Closed
@slspencer slspencer merged commit 83cf622 into develop Sep 21, 2023
10 checks passed
@slspencer slspencer deleted the issue-1024-fix-logging branch September 21, 2023 16:23
@DSCaskey DSCaskey mentioned this pull request Sep 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slspencer slspencer slspencer approved these changes

Assignees

@DSCaskey DSCaskey

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: App is excessively logging debug() messages
2 participants
@DSCaskey @slspencer