Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert logging warnings #1029

Merged
merged 1 commit into from
Oct 7, 2023
Merged

Conversation

DSCaskey
Copy link
Contributor

@DSCaskey DSCaskey commented Oct 7, 2023

This reverts some of the warning() logging messages back to debug() messages so that a warning dialog does not pop up. In these cases it's perfectly acceptable to only report the debug() messages while running in debug mode.

Fixes issue #1028

@DSCaskey DSCaskey added the bug label Oct 7, 2023
@DSCaskey DSCaskey requested a review from csett86 October 7, 2023 05:17
@DSCaskey DSCaskey self-assigned this Oct 7, 2023
@what-the-diff
Copy link

what-the-diff bot commented Oct 7, 2023

PR Summary 🚀

Hello wonderful team! 😊 Here are the marvellous changes we have made to the code base:

  • Change of Statements in Multiple Files 😇
    In files like dialoghistory.cpp, groups_widget.cpp, mainwindow.cpp, and vabstractpattern.cpp, we've made the code a little more friendly for our developers. We have switched qWarning() statements to qDebug() statements. 🔄 This is fantastic for us, as it makes debugging easier, leading to a more efficient troubleshooting, and subsequently, a smoother software. 😉

  • Syntax Update in 'mainwindowsnogui.cpp' 📘
    We've given mainwindowsnogui.cpp a nice little readability boost by replacing 'not' keyword with '!'. Instances include changing expressions such as if (not dir.exists(path)) to if (!dir.exists(path)) and similar. This modernizes our syntax, makes our code more readable and thus helps us maintain the high quality of our software! 🌟

  • Another Statement Switch in 'fvupdater.cpp' 🔄
    Again, for the sake of simplifying and improving our debugging process, the qWarning() statement in fvupdater.cpp has been changed to qDebug(). More simplicity, less nuisances. 😌

Awesome job everyone! Let's keep smashing it and creating a more friendly environment for both our developers and our users. 👏💪 Let's do this! 🌈🚀

@ghost
Copy link

ghost commented Oct 7, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@csett86 csett86 linked an issue Oct 7, 2023 that may be closed by this pull request
Copy link
Collaborator

@csett86 csett86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@DSCaskey
Copy link
Contributor Author

DSCaskey commented Oct 7, 2023

@csett86

Thanks. I figured I'd have you review it... I think Susan's busy lately. I'll merge it as soon as the checks complete.

@DSCaskey DSCaskey merged commit 350a5b3 into develop Oct 7, 2023
10 checks passed
@DSCaskey DSCaskey deleted the issue-1028-fix-logging-warnings branch October 7, 2023 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Change in logging behavior is now popping up warnings unecessarily
2 participants