Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert qCWarning() to qCDebug() #1035

Merged
merged 1 commit into from
Oct 21, 2023

Conversation

DSCaskey
Copy link
Contributor

This reverts inadvertant qCWarning() to a qCDebug().

Fixes issue #1034

@DSCaskey DSCaskey added the bug label Oct 21, 2023
@DSCaskey DSCaskey requested a review from csett86 October 21, 2023 20:45
@DSCaskey DSCaskey self-assigned this Oct 21, 2023
@what-the-diff
Copy link

what-the-diff bot commented Oct 21, 2023

PR Summary

  • Polished Logging Approach 🌳

A mild change in the logging mechanism was introduced in a central part of the code. This change swapped a warning-style log statement to a more serene debug-style log. This helps in ensuring that our logs are concise, accurate, and don't overload us with unnecessary information.

By this adaptation, we're making our application even smarter and smoother. Great work, team! 🚀 Keep up the fantastic progress! 💪

@csett86 csett86 linked an issue Oct 21, 2023 that may be closed by this pull request
Copy link
Collaborator

@csett86 csett86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ghost
Copy link

ghost commented Oct 21, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@DSCaskey
Copy link
Contributor Author

@csett86

Thank you sir.

Hopefully this is the last warning to revert. I'll merge once the checks complete.

@DSCaskey DSCaskey merged commit 3559a55 into develop Oct 21, 2023
10 checks passed
@DSCaskey DSCaskey deleted the issue-1034-revert-seamlyme-warning branch October 21, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Starting SeamlyMe throws inadvertant warning.
2 participants