Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add seamlyme splash screen #1048

Merged
merged 1 commit into from
Nov 28, 2023
Merged

feat: add seamlyme splash screen #1048

merged 1 commit into from
Nov 28, 2023

Conversation

DSCaskey
Copy link
Contributor

This adds a "Coming Soon..." splash screen (w/delay) to the SeamlyMe application.

coming_soon

resolves issue #1047

@ghost
Copy link

ghost commented Nov 28, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link

what-the-diff bot commented Nov 28, 2023

🎉 Pull Request Summary 🎉

This PR consists of several revamps and fresh introductions to our codebase that make our system more effective and up-to-date. Here is the simplified journey of this update:

  • Capitalization adjustment in main.cpp files of both seamly2d and seamlyme directories: This may seem like a small tweak, but it actually enhances our code readability and consistency! Good job, team! 😊

    • The function name InitHighDpiScaling was tastefully renamed as initHighDpiScaling.
  • Enhancements and additions to main.cpp in seamlyme: 🔥

    • The file now has a fresh header with the latest date and updated copyright information.
    • Welcoming our new participant - QSplashScreen. 👏
    • Some function name transforms to raise our readability bar: The ProcessCMD is now known as processCommandLine! 😄
    • Say hello to two new functions: NewMainWindow and ParseCommandLine. These additions will no doubt enhance our application's functionality. 😎
    • The faithful InitTrVars function had an update to keep it in sync with our needs.
    • There's a new slot in town! –processCommandLine.
  • More function renaming in mapplication.cpp and mapplication.h in seamlyme: 🔄

    • Continuing our naming consistency endeavor, the ProcessCMD function metamorphosed into processCommandLine.
    • The InitTrVars function also received some updates here.
  • Sprucing up seamlyme.pro: 🎈

    • The addition of a new resource file splash.qrc sets the ground for an exciting visual update.
    • Added a new image file Coming Soon.png to the resource file, keeping our users in suspense! 🙈
  • Renaming functions in def.cpp and def.h in src/libs/vmisc: 🔄😄

    • Maintaining our style guide across codebase, InitHighDpiScaling was renamed as initHighDpiScaling.

Remember every edit, every line of code adds value to our great product! Let's keep up the good work everyone! 🚀👩‍💻👨‍💻🌟

@DSCaskey DSCaskey merged commit aec2361 into develop Nov 28, 2023
10 checks passed
@DSCaskey DSCaskey deleted the add-me-splash-screen branch November 28, 2023 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants