Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enhance groups dock #1049

Merged
merged 2 commits into from
Dec 1, 2023
Merged

feat: enhance groups dock #1049

merged 2 commits into from
Dec 1, 2023

Conversation

DSCaskey
Copy link
Contributor

This makes the following enhancements to the Groups Manager dock:

  • Retranslate dock ui when language is changed.
  • Add beep sound when item selected is locked.
  • Change "rename" in context menu to "edit".
  • Header names and subsequent abbreviation letter are translated.

fixes issue #1001

@DSCaskey DSCaskey self-assigned this Nov 28, 2023
@DSCaskey DSCaskey linked an issue Nov 28, 2023 that may be closed by this pull request
BUG: groups / piece dock does not refresh when changing language. #1001
Closed
@ghost
Copy link

ghost commented Nov 28, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@slspencer slspencer merged commit fd05e62 into develop Dec 1, 2023
10 checks passed
@slspencer slspencer deleted the enhance-groups-dock branch December 1, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slspencer slspencer slspencer approved these changes

Assignees

@DSCaskey DSCaskey

Labels
Draft mode enhancement translations UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: groups / piece dock does not refresh when changing language.
2 participants
@DSCaskey @slspencer