Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add notch subtype to context menu #1051

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

DSCaskey
Copy link
Contributor

@DSCaskey DSCaskey commented Dec 6, 2023

This adds a notch subtype menu item to the Pattern Piece -> Path context menu. It allows a quick way to set notch subtypes without having to go back and forth between the Paths & Notches tabs.

notch_subtype

The Notch -> Type -> None shortcut has also be changed to Shift - N to avoid conflict with the Notch -> Subtype -> Intersection shortcut Shift - X.

This resolves issue #1045

@ghost
Copy link

ghost commented Dec 6, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link
Collaborator

@csett86 csett86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, the new context menu also works fine with macOS

@slspencer slspencer merged commit 9891812 into develop Dec 15, 2023
10 checks passed
@slspencer slspencer deleted the add-notch-subtype-to-context-menu branch December 15, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add a notch Subtype submenu to the mainpath context menu.
3 participants