Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify how to run fast-trips in ReadMe.md #42

Closed
e-lo opened this issue Feb 2, 2017 · 12 comments
Closed

Clarify how to run fast-trips in ReadMe.md #42

e-lo opened this issue Feb 2, 2017 · 12 comments
Assignees

Comments

@e-lo
Copy link
Member

e-lo commented Feb 2, 2017

ReadMe / Quick Start needs an example of what you actually write when you run Fast-Trips.

  • What are various config options?
  • What are required inputs and in what order to you specify them?

runtest should probably also be renamed to runXXX where XXX implies an actual fast-trips run.

@e-lo e-lo added this to the Appcon Tutorial milestone Apr 27, 2017
@e-lo e-lo self-assigned this Apr 27, 2017
@lmz
Copy link
Member

lmz commented May 8, 2017

FYI I always run from command line so I resurrected runTest.py as runFastTrips.py: https://github.com/MetropolitanTransportationCommission/fast-trips/blob/develop/scripts/runFastTrips.py

@e-lo
Copy link
Member Author

e-lo commented May 8, 2017

@lmz : if you are going to run from command line, please make sure it is logging the parameters you pass it somewhere ;-)

@lmz
Copy link
Member

lmz commented May 8, 2017

I think everything is in the ft_output_config.txt except for the pathweights and input config files themselves, which I could add.

lmz pushed a commit that referenced this issue May 8, 2017
@e-lo
Copy link
Member Author

e-lo commented May 8, 2017

These commits break running it from run_fasttrips.py: see my comments
92d71c3

@e-lo
Copy link
Member Author

e-lo commented May 8, 2017

[ and now you can use the tests! ;-) ]

@lmz
Copy link
Member

lmz commented May 8, 2017

How are you running the tests?

@lmz
Copy link
Member

lmz commented May 8, 2017

oh nm - i see. running "pytest"

@lmz
Copy link
Member

lmz commented May 8, 2017

Will fix tests. Sorry, I knew renaming to input_network_dir would break them and forgot to fix, but that's what it was originally called and I thought the abbreviation unnecessary 😮

@e-lo
Copy link
Member Author

e-lo commented May 8, 2017

AHA - OMG I have been trying to figure out what was going on but duh... net --> network . Glad one of us [ you ] can read. The error [TypeError: run_setup() takes at least 6 arguments (7 given)]
was non-obvious [to me]

@lmz
Copy link
Member

lmz commented May 8, 2017

👍 yea, I think that's all it was, the tests run fine for me now

e-lo added a commit that referenced this issue May 9, 2017
Partial fix of #42 - need to add in info on running from command line.
@e-lo
Copy link
Member Author

e-lo commented May 9, 2017

@lmz : please add command used for running the test scenario

https://github.com/MetropolitanTransportationCommission/fast-trips/tree/develop#running-fast-trips

@e-lo e-lo assigned lmz and unassigned e-lo May 9, 2017
@e-lo
Copy link
Member Author

e-lo commented Jun 26, 2017

i added this.

@e-lo e-lo closed this as completed Jun 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants