Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change simulation_iteration to a reset_bump_iter boolean. #99

Closed
danielsclint opened this issue Oct 26, 2017 · 3 comments
Closed

Change simulation_iteration to a reset_bump_iter boolean. #99

danielsclint opened this issue Oct 26, 2017 · 3 comments
Assignees
@danielsclint

Comments

@danielsclint
Copy link

The simulation_iteration argument seems weird when running the calculate cost in stand-alone (static) mode. The simulation_iteration is only used to reset the bump_iter column on simulation_iteration 0. I argue in favor of a keyword arg for reset_bump_iter that the simulation loop can call as needed.

https://github.com/BayAreaMetro/fast-trips/blob/5e504cb3319b58faac3aca1310cb4ad08dc44ed8/fasttrips/PathSet.py#L665
danielsclint pushed a commit to danielsclint/fast-trips that referenced this issue Oct 26, 2017
Remove simulation_iteration from calculate_cost static function. (Fas…
7e8d574 
…t-Trips#99)
@danielsclint danielsclint self-assigned this Oct 26, 2017
@e-lo
Copy link
Member

e-lo commented Oct 26, 2017

totally agreed.

@e-lo
Copy link
Member

e-lo commented Oct 26, 2017

Clint - if your commit resolves this issue can you create a pull request so that I can test and merge it? thx!

e-lo pushed a commit that referenced this issue Nov 1, 2017
@e-lo
Addresses Issue #99 and full implementation of Asana Calculate Cost S…
b66653a 
…cript (#100)

* Update the DF exporter to include a date stamp. #93

* For simplicity sake and debugging, limit the number of processes to one.

* Script to expose calculate_cost function. This is the most basic implementation. More changes to come.

* Remove simulation_iteration from calculate_cost static function. (#99)

* Clean up data types so joins work properly.

* Preserve fractions of seconds for debugging purposes.

* Add Capacity Constraint to calculate_cost test.

* Full implementation of calculate_cost script with tests and control data for comparison of results.

* Move merge_two_dict to Util as a static method and add doc string. #100

* Add docstrings to all the methods in test_calculate_cost.py. #100

* Move calculate_cost script to scripts folder. Keep nosetest in tests folder and point to the script in the scripts to run. #100

* add scripts to install for tests.

* Update travis test.

* Commit test.

* another travis test.

* more travis changes.

* travis with miniconda

* update miniconda install

* breakup transitfeed install

* another try

* add requirements.

* pip/

* try again.

* travis

* Add pytest.

* add psutil.

* Final changes for Travis (I hope).

* Add build status to readme.

* Clean-up build bad
@danielsclint
Copy link
Author

This was addressed on Pull Request #100.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielsclint danielsclint

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@e-lo @danielsclint