Adding fares functionality #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update fares with develop branch
Passes flat fares (no transfer logic) and vot to c++ extension, which incorporates fares. Still todo: incorporate into python cost calcs and transfer stuff of course. Also test that python and c++ are consistent and get the time-of-day stuff correct.
Passing them to c++ extension
todo: implement on python side
And add fares before the weight-splitting
Conflicts: fasttrips/Assignment.py fasttrips/Passenger.py fasttrips/PathSet.py fasttrips/Route.py
Also read fare transfer rules on c++ side
(B0 and B4) and a single bus shuttle so we can get a transfer within bus_local_fare_pm
from fare_attributes_ft.txt
taz/stop pair should be unique in this file
So don't reverse walk access links
Conflicts: fasttrips/Assignment.py fasttrips/PathSet.py
Fixed bug in write_paths() call
Otherwise we assess too much fare, oops
(todo: verify)
e-lo
reviewed
Feb 9, 2017
fasttrips/Passenger.py
Outdated
| `pf_probability` float64 the probability of the path | ||
| `pf_initcost` float64 the initial cost of the entire path |
There was a problem hiding this comment.
"INIT" something in this case is sort of like "FINAL" before "FINAL FINAL". It might be good at some point to change this { and its siblings } to be named after their stage. I.e. "Cost for Pathfinding" rather than "initial cost".
e-lo
reviewed
Feb 9, 2017
fasttrips/Passenger.py
Outdated
| @@ -509,7 +509,10 @@ def setup_passenger_pathsets(self, iteration, stops, trip_id_df, trips_df, modes | |||
| `pf_iteration` int64 iteration in which these paths were found | |||
| `pathnum` int64 the path number for the path within the pathset | |||
| `pf_cost` float64 the cost of the entire path | |||
| `pf_fare` float64 the fare of the entire path | |||
There was a problem hiding this comment.
The difference of "cost" and "fare" is not initially obvious.
Perhaps we should use Util instead of cost? Other thoughts?
|
LGTM at a very high-level view. |
|
Note that adding fares adds significant (4X) processing time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.