Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide instant redirection page from history #742

Open
NewsGuyTor opened this issue Oct 8, 2022 · 13 comments
Open

Hide instant redirection page from history #742

NewsGuyTor opened this issue Oct 8, 2022 · 13 comments
Labels
good first issue Good for newcomers no stale issues with this label won't stale.

Comments

@NewsGuyTor
Copy link

NewsGuyTor commented Oct 8, 2022

It's really annoying to click on a bit.ly link or something, and then not have the back button work because the previous page is the redirection HTML and not the page you were on.

Thankfully, it should be really easy to fix. I think either adding this in before-navigate.js should do it:

window.location.replace(url);

or this:

history.deleteUrl()

@lostdusty
Copy link
Contributor

@reashetyrr what do you think?

@lostdusty lostdusty added the good first issue Good for newcomers label Nov 21, 2022
@ArslanYM
Copy link

Can I work on this?

@0xc60f
Copy link
Member

0xc60f commented Mar 27, 2023

Can I work on this?

Sure!

@ArslanYM
Copy link

@0xc60f i made the changes but i dont know how to check if its working or not. Theres no guide for setting up the project locally

@NotAProton
Copy link
Member

NotAProton commented Mar 30, 2023

@ArslanYM, use the mv-3 branch, Reashetyrr did a webinar on developing for fastforward https://www.youtube.com/watch?v=cwaUa48YCXs&t=620s

@ArslanYM
Copy link

@NotAProton I am able to successfully build the extension but my question is how do i check if my changes are working or not. I dont know how to do that

@NotAProton
Copy link
Member

NotAProton commented Mar 31, 2023

@ArslanYM The extension is built in the builds folder, load it into your browser and test it. You can find example links in PRs to the mv3 branch like #913. You can also directly open the before navigate page by using this link https://fastforward.team/bypassed?target=https%3A%2F%2Fexample.com/ with fastforward (MV-3) installed

@kevin01523
Copy link

@NotAProton will this work to fix the current crowdbypass block issue for chrome or even firefox?

basically instead of extension://ldcclmkclhomnpcnccgbgleikchbnecl/html/crowd-bypassed.htmlget=

we use
https://fastforward.team/bypassed?target=

i seem to recall the old precursor to fastforward seems to use a similar method for crowdbypass

i maybe recalling something wrong though

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

This issue is stale because it has been open for 30 days with no activity. To undo this, make some activity on this issue or create a new one.

@github-actions github-actions bot added the stale label Sep 4, 2023
@NewsGuyTor
Copy link
Author

Bump

@github-actions github-actions bot removed the stale label Sep 10, 2023
@lostdusty
Copy link
Contributor

Does this still happens on MV3?

@github-actions
Copy link

This issue is stale because it has been open for 30 days with no activity. To undo this, make some activity on this issue or create a new one.

@github-actions github-actions bot added the stale label Sep 25, 2023
@0xc60f 0xc60f added no stale issues with this label won't stale. and removed stale labels Oct 20, 2023
@kiraio-moe
Copy link
Contributor

It's going back to original page, but the redirection page history are still saved.
I'll try to work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers no stale issues with this label won't stale.
Projects
None yet
Development

No branches or pull requests

7 participants