Fix ambiguous overload compile errors #1619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shlomozippel
force-pushed
the
fix_compile_errors
branch
from
ab165d3
to
55bed0a
Compare
|
Thank you for this contribution - getting things working with the esp 3.0 core is something we're trying to get to as quickly as we can. All of the help is very much appreciated! |
dmadison
added a commit
to dmadison/FastLED
that referenced
this pull request
May 28, 2024
This function changed its signature with FastLED#1619. This corrects the copydetails commands to the new signature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #1553, #1555 , #1605
This only fixes the issues in noise.cpp. There are other errors when building for esp32 with the new 3.0 core mostly related to upgrading from espidf 4.x to 5.x which has a new driver model. The RMT and I2S code needs to be updated, but that's a larger change for another day :)