Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support windows-1251 encoding for async (non-blocking) parsing #50

Open
prophe05 opened this issue Jul 28, 2017 · 1 comment
Open

Support windows-1251 encoding for async (non-blocking) parsing #50

prophe05 opened this issue Jul 28, 2017 · 1 comment

Comments

@prophe05
Copy link

Hello.

I tried to parse xml with windows-1251, but caught error:

com.fasterxml.aalto.WFCException: Unsupported encoding 'windows-1251': only UTF-8 and US-ASCII support by async parser

Any plans to support encodings differing from UTF-8 and US-ASCII.

Or did I miss something?

@cowtowncoder
Copy link
Member

cowtowncoder commented Dec 4, 2017

No plans to add handling of other encodings for non-blocking parsers at this point.

Technical challenge is that non-blocking parsers is byte-based, not character based (Reader), so support would require lots of code duplication.

@cowtowncoder cowtowncoder changed the title Support windows-1251 encoding. Support windows-1251 encoding for async (non-blocking) parsing Dec 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants