Jigsaw support #117
Jigsaw support #117
Conversation
|
Would it be possible to add bit of description of what changes are, and for why? |
reverted changes to JsonAlias
|
Sure. |
|
|
||
| <osgi.export>com.fasterxml.jackson.annotation.*;version=${project.version}</osgi.export> | ||
| <maven-compiler-plugin.version>3.6.1</maven-compiler-plugin.version> | ||
| <maven-bundle-plugin.version>3.2.0</maven-bundle-plugin.version> |
There was a problem hiding this comment.
version upgrades are required for both in order to handle maven-module.java
| <instructions> | ||
| <_noee>true</_noee> | ||
| <_failok>true</_failok> | ||
| <Include-Resource>module-info.class=target/classes/module-info.class</Include-Resource> |
There was a problem hiding this comment.
required for bundle plugin to include module-info.class in built jar (and in turn, to build modular jar)
| <configuration> | ||
| <instructions> | ||
| <_noee>true</_noee> | ||
| <_failok>true</_failok> |
There was a problem hiding this comment.
without failok build fails:
[ERROR] Bundle com.fasterxml.jackson.core:jackson-annotations:bundle:2.9.0-SNAPSHOT : Invalid class file module-info.class (java.lang.ArrayIndexOutOfBoundsException: 19)
| <version>${maven-bundle-plugin.version}</version> | ||
| <configuration> | ||
| <instructions> | ||
| <_noee>true</_noee> |
There was a problem hiding this comment.
without noee build fails:
[ERROR] An internal error occurred
java.lang.IllegalArgumentException: Null query
|
Ok so... does this mean that only JDK9 build would be enabled for Travis? But also that that version is not yet available? |
|
Before JDK 9, what we can do is #123 which I can add for |
|
Closing in favor of new attempt for 2.10 |
FasterXML/jackson-databind#1536