Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove junit 4.x dependency from jackson-base 2.18.x to help junit5 migration #68

Closed
cowtowncoder opened this issue Apr 21, 2024 · 1 comment · Fixed by FasterXML/jackson-jaxrs-providers#188
Closed

Remove junit 4.x dependency from jackson-base 2.18.x to help junit5 migration #68

cowtowncoder opened this issue Apr 21, 2024 · 1 comment · Fixed by FasterXML/jackson-jaxrs-providers#188
Assignees
@cowtowncoder

Comments

@cowtowncoder
Copy link
Member

Since core Jackson packages (annotations, streaming, databind) have been upgraded to JUnit 5, it does not make sense to have dependency from parent jackson-base to Junit 4, even if other components still rely on JUnit 4.
Let's remove dependency, leaving managed dependency, and make individual projects depend on JUnit version they need.
@cowtowncoder
Copy link
Member Author

/cc @JooHyukKim @pjfanning @FasterXML/datatype-collections -- will be changing jackson-base, fixing dependencies on repos.

@cowtowncoder cowtowncoder self-assigned this Apr 21, 2024
cowtowncoder added a commit that referenced this issue Apr 21, 2024
@cowtowncoder
Merge pull request #69 from FasterXML/tatu/2.18/68-rm-junit4-dep
ed1b496 
Fix #68: change junit4 dep from regular to managed
@JooHyukKim JooHyukKim mentioned this issue Apr 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cowtowncoder cowtowncoder

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add explicit JUnit 4 dependency due to jackson-base refactoring JooHyukKim/jackson-jaxrs-providers
1 participant
@cowtowncoder