Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add platform dependency to Jackson BOM for Gradle consumers #33

Merged
merged 1 commit into from
May 23, 2020
Merged

Add platform dependency to Jackson BOM for Gradle consumers #33

merged 1 commit into from
May 23, 2020

Conversation

jjohannes
Copy link
Contributor

See this mailing list discussion and this blog post.

This configures the 'gradle-module-metadata-maven-plugin' to write
and publish a Gradle Module Metadata file that contains a platform
dependency to the Jackson BOM.

All projects that have jackson-base as parent should then activate
this plugin an the use of Gradle Module Metadata by adding:

  <!-- do_not_remove: published-with-gradle-metadata -->

right below the <project> opening tag

As well as:

  <plugin>
    <groupId>de.jjohannes</groupId>
    <artifactId>gradle-module-metadata-maven-plugin</artifactId>
  </plugin>

to the <plugins> block.

This configures the 'gradle-module-metadata-maven-plugin' to write
and publish a Gradle Module Metadata file that contains a platform
dependency to the Jackson BOM.

All projects that have jackson-base as parent should then activate
this plugin an the use of Gradle Module Metadata by adding:

  <!-- do_not_remove: published-with-gradle-metadata -->

right below the <project> opening tag

As well as:

  <plugin>
    <groupId>de.jjohannes</groupId>
    <artifactId>gradle-module-metadata-maven-plugin</artifactId>
  </plugin>

to the <plugins> block.
@cowtowncoder
Copy link
Member

Perfect! Only one more practical thing -- have I asked for CLA yet? If not (apologies if I have, sometimes my check fails), I'd need one from:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

(or matching corporate CLA, if preferable, most contributions are under individual one)
and it's only needed once for all contributions.
Usual method is to print, fill & sign, scan/photo, email to info at fasterxml dot com.
Once I get that I can merge these patches in.

@jjohannes
Copy link
Contributor Author

@cowtowncoder I was wondering about CLA, but was not sure where to send it. Thanks for the explanation. I sent a mail.

@cowtowncoder cowtowncoder merged commit d47e92e into FasterXML:2.12 May 23, 2020
@cowtowncoder cowtowncoder added this to the 2.12.0 milestone May 23, 2020
@cowtowncoder
Copy link
Member

Merged, published (mvn deploy) snapshot; manually merged to master as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants