fix regression caused by looksLikeValidNumber

FasterXML · Mar 16, 2024 · 778d0bd · 778d0bd
1 parent 5e109b2
commit 778d0bd
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/main/java/com/fasterxml/jackson/core/io/NumberInput.java b/src/main/java/com/fasterxml/jackson/core/io/NumberInput.java
@@ -39,7 +39,7 @@ public final class NumberInput
      * @since 2.17
      */
     private final static Pattern PATTERN_FLOAT = Pattern.compile(
-          "[+-]?[0-9]+(\\.[0-9]+)?([eE][+-]?[0-9]+)?");
+          "[+-]?([0-9]+)?(\\.[0-9]+)?([eE][+-]?[0-9]+)?");
 
     /**
      * Fast method for parsing unsigned integers that are known to fit into
@@ -578,6 +578,6 @@ public static BigInteger parseBigIntegerWithRadix(final String s, final int radi
      * @since 2.17
      */
     public static boolean looksLikeValidNumber(final String s) {
-        return (s != null) && PATTERN_FLOAT.matcher(s).matches();
+        return s != null && PATTERN_FLOAT.matcher(s).matches() && !s.trim().isEmpty();
     }
 }
diff --git a/src/test/java/com/fasterxml/jackson/core/io/NumberInputTest.java b/src/test/java/com/fasterxml/jackson/core/io/NumberInputTest.java
@@ -70,6 +70,11 @@ public void testLooksLikeValidNumber()
         assertTrue(NumberInput.looksLikeValidNumber("-1"));
         assertTrue(NumberInput.looksLikeValidNumber("0001")); // non-JSON
 
+        // https://github.com/FasterXML/jackson-databind/issues/4435
+        assertTrue(NumberInput.looksLikeValidNumber(".01"));
+        assertTrue(NumberInput.looksLikeValidNumber("+.01"));
+        assertTrue(NumberInput.looksLikeValidNumber("-.01"));
+
         assertTrue(NumberInput.looksLikeValidNumber("0.01"));
         assertTrue(NumberInput.looksLikeValidNumber("-0.10"));
         assertTrue(NumberInput.looksLikeValidNumber("+0.25")); // non-JSON
@@ -84,6 +89,7 @@ public void testLooksLikeValidNumber()
 
         assertFalse(NumberInput.looksLikeValidNumber(""));
         assertFalse(NumberInput.looksLikeValidNumber("   "));
+        assertFalse(NumberInput.looksLikeValidNumber("."));
         assertFalse(NumberInput.looksLikeValidNumber("10_000"));
     }
 }