Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LICENSE misssing from 2.15.1 jar #1032

Closed
pjfanning opened this issue May 18, 2023 · 4 comments
Closed

LICENSE misssing from 2.15.1 jar #1032

pjfanning opened this issue May 18, 2023 · 4 comments

Comments

@pjfanning
Copy link
Member

Was removed by c04e924#diff-8eac27e2b7403d363ecdb0a19ea08fafe1aa78484e74fb74664d50f202bc2e94

I think it would be better to have the LICENSE in the jar. The one that was removed by the commit was probably fine.

@cowtowncoder
Copy link
Member

@pjfanning There is root-level LICENSE that "build-helper-maven-plugin" used to include. But maybe later changes wrt license processing broke this somehow? Ideally we would not have 2 LICENSES: main level one is needed for Github UI so that seemed like better choice than something under ``src/main/resources/META-INF/LICENSE`.

Either way, yes, we do want LICENSE included and its dropping was not intentional

@cowtowncoder
Copy link
Member

Looks like 2.15.0 jar does have META-INF/LICENSE but 2.15.1 not. I think something with added post-processing (to produce META-INF/FastDoubleParser-LICENSE and META-INF/bigint-LICENSE) broke inclusion of "main" LICENSE. :-(

@pjfanning
Copy link
Member Author

I tried a few maven plugins but still struggling to get the LICENSE included. Is it ok if I just copy it to src/resources/META-INF again? This change is still going to be painful because FastDoubleParser has clashing files that we need to keep (but rename).

I already had to rename the NOTICE as src/resources/META-INF/jackson-core-NOTICE and rename it as part of the maven shade task execution. The plan would to do something similar for the LICENSE file.

@cowtowncoder
Copy link
Member

@pjfanning yes, if nothing else works (easily enough) ok to duplicate.

@cowtowncoder cowtowncoder changed the title add LICENSE to jar LICENSE misssing from 2.15.1 jar May 18, 2023
cowtowncoder added a commit that referenced this issue May 18, 2023
cowtowncoder added a commit that referenced this issue May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@cowtowncoder @pjfanning and others