Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate remaining test to JUnit 5 #1239

Closed
timo-a opened this issue Mar 13, 2024 · 3 comments
Closed

Migrate remaining test to JUnit 5 #1239

timo-a opened this issue Mar 13, 2024 · 3 comments

Comments

@timo-a
Copy link
Contributor

timo-a commented Mar 13, 2024

Since this is going to take several PRs, this issue is intended to coordinate them.

original PR: #1237

@cowtowncoder
Copy link
Member

First PR merged; looks like there are 125 cases of BaseTest being extended so likely target count.

May need 3 - 5 PRs depending on what works best. Since 2.18 branch only now starting, ok to target against 2.17.

@timo-a
Copy link
Contributor Author

timo-a commented Mar 23, 2024

I guess we're done here, junit-vintage-engine is gone from the pom files of master, 2.17 and 2.28.

@timo-a timo-a closed this as completed Mar 23, 2024
@cowtowncoder
Copy link
Member

Indeed! Thank you for doing this, @timo-a !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants