Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update(tests): migrate JUnit 4 code to JUnit 5 in core.read #1245

Merged
merged 17 commits into from
Mar 22, 2024
Merged

update(tests): migrate JUnit 4 code to JUnit 5 in core.read #1245

merged 17 commits into from
Mar 22, 2024

Conversation

timo-a
Copy link
Contributor

@timo-a timo-a commented Mar 21, 2024

Part 3 of the remaining junit 5 migrations - Tests in core.read that extend BaseTest.
Probably needs to be rebased after part 2 is merged.

@timo-a
update(tests, async): automatic migration of tests extending AsyncTes…
6e9762c 
…tBase
@timo-a
update(tests, async): manual fixes
fc3a412
@timo-a
update(tests, async): Switch to JUnit5TestBase as superclass for Asyn…
5153370 
…cTestBase
@timo-a
disable failing tests (they weren't executed previously)
e7f9a27
@timo-a
update(tests, async): remove obsolete public modifier and test prefix
9c5071e
@timo-a
update(tests, async): cleanup
3d0968b
@timo-a
update(tests, core/read): migrate core.read from JUnit 4 to JUnit 5
4b025c2
@timo-a
manual fixes
f807100
@timo-a
update(tests, core/read): replace BaseTest as super class
c77aaca
@timo-a
update(tests, core/read): align JUnit5TestBase with BaseTest
07822a9
@timo-a
update(tests, core/read): replace remaining uses of BaseTest
9fb174f
@timo-a
update(tests, core/read): remove obsolete public modifier and test pr…
4107662 
…efix
@timo-a
update(tests, core/read): fix build
7e7bfe1
@timo-a
update(tests, core/read): apply remaining cleanup recipes
d16e1f1
@timo-a
update(tests, core/read): clean super class references
233d034
@timo-a timo-a mentioned this pull request Mar 21, 2024
Closed
@cowtowncoder cowtowncoder marked this pull request as ready for review March 22, 2024 01:26
@cowtowncoder cowtowncoder merged commit 7cece7e into FasterXML:2.17 Mar 22, 2024
5 checks passed
@cowtowncoder
Copy link
Member

Ugh. Merging this to master is a royal PITA. Just because there are so many conflicts...
not sure what if anything could be done to that; will be very glad when conversion is over :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cowtowncoder cowtowncoder cowtowncoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timo-a @cowtowncoder