move pool reference from BufferRecycler to IOContext #1107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return new IOContext(_streamReadConstraints, _streamWriteConstraints, _errorReportConfiguration, | ||
| _getBufferRecycler(), |
There was a problem hiding this comment.
Alas, I don't like this, due to backwards-(in)compatibility aspect -- this will immediately break usage by those JsonFactory sub-classes that override this method (I think CSV one does, probably others).
Or rather, require synchronized changes (technically allowed as per my "internal vs external" compatibility goals.. as long as all 2.16 components work together).
|
I actually prefer the other approach, even if at some point I was thinking that maybe Will add a note on the other PR. |
|
We preferred and found an agreement on the other solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative solution for the problem reported and tentatively fixed here.
This time I moved the pool reference from the
BufferRecyclerto theIOContextinstance. In this way I got rid of thatwithPoolmethod and now it'sIOContextresponsibility to pass to theBufferRecyclerthe instance of the pool to which it has to be eventually released.This solution has the advantage of exposing a much cleaner API, but the drawback of moving the pool reference away from its own
BufferRecycler. I think that this is fine as long as theBufferRecycleris always exclusively used by theIOContextand there aren't other classes that reference it either now or in future.@cowtowncoder @pjfanning Please let me know if this solution is more acceptable than the one that I proposed yesterday (I believe so).