Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fastdoubleparser 1.0.0 (#1163) #1164

Merged

Conversation

pjfanning
Copy link
Member

backport #1163

@pjfanning
Copy link
Member Author

@cowtowncoder this would almost certainly backport cleanly to 2.15 if there were any plans for a future 2.15 release

2.15 uses fastdoubleparser 0.9.0 already so same change should work there too

@JooHyukKim
Copy link
Member

this would almost certainly backport cleanly to 2.15

If so, we need to create a new PR based on 2.15 branch. That way we can just forward merge.

@cowtowncoder
Copy link
Member

@JooHyukKim Normally yes, but unfortunately pom.xml changes are different due to merge conflict wrt release version. As a result, manual merge (or separate PRs) are typically needed.

@pjfanning Yes, I think 2.15 backport would be welcome too if and when it's easy to do. There will likely be one more patch release from that branch (2.15.4).

@cowtowncoder cowtowncoder merged commit 126a5d7 into FasterXML:2.17 Dec 11, 2023
5 checks passed
@cowtowncoder
Copy link
Member

@pjfanning whops. Did not notice but this was (accidentally I assume) against 2.17, not 2.16?

@pjfanning
Copy link
Member Author

This PR was targeting the wrong barnch. I have created #1165 for 2.16 branch.

@pjfanning pjfanning deleted the fastdoubleparser-1.0.0-backport branch December 11, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants