Allow configuring DefaultPrettyPrinter separators for empty Arrays and Objects
#1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cowtowncoder
added
the
cla-needed
|
@gulecroc Looks good in general: thank you for the changes requested! I will make one small change for backwards compatibility but I think we are good otherwise. One process thing: if you haven't sent CLA yet (I don't think so but sometimes I forget), we'd need one from here: https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf and it's usually easiest to print, fill & sign, scan/photo, email to Looking forward to merging this nice addition. |
|
Made the compatibility change so all we need is CLA and can merge this in! |
|
Hi @cowtowncoder, I just sent the CLA. |
cowtowncoder
added
2.17
|
CLA received, can proceed with merging. |
cowtowncoder
changed the title
DefaultPrettyPrinter separators for empty Objects and Arrays
cowtowncoder
changed the title
DefaultPrettyPrinter separators for empty Objects and ArraysDefaultPrettyPrinter separators for empty Arrays and Objects
cowtowncoder
approved these changes
Jan 1, 2024
cowtowncoder
added a commit
that referenced
this pull request
Jan 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1128