Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1195: add actual BufferRecycler reuse #1196

Merged
merged 13 commits into from
Jan 23, 2024
Merged

Fix #1195: add actual BufferRecycler reuse #1196

merged 13 commits into from
Jan 23, 2024

Conversation

cowtowncoder
Copy link
Member

No description provided.

@cowtowncoder
Copy link
Member Author

@mariofusco I think this is quite similar to what you suggested and should work well (not perfect obviously, but relatively limited changes). WDYT?
I think life-cycle wrt pool will work ok in this particular case (that is, use of ByteArrayBuilder/SegmentedStringWriter by databind), even if not quite as clean as ideally it'd be.

@cowtowncoder cowtowncoder mentioned this pull request Jan 20, 2024
Closed
@cowtowncoder cowtowncoder merged commit 28b0dd3 into 2.17 Jan 23, 2024
5 checks passed
@cowtowncoder cowtowncoder deleted the tatu/2.17/1195-reuse-bufferrecycler branch January 23, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariofusco mariofusco mariofusco left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cowtowncoder @mariofusco