Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new method JsonGenerator.isEnabled(JsonWriteFeature) #1198

Conversation

JooHyukKim
Copy link
Member

blocks #1197

@cowtowncoder
Copy link
Member

As per my note on the other PR: let's not add this -- there is a reason this method is not included in JsonGenerator.
Naming here is bit unfortunate, but basically:

  1. JsonGenerator is API for generators, NOT specific to. JSON, but
  2. JsonWriteFeature IS JSON-specific, and should not be referenced for general, non-JSON-specific code

Instead, access from actual JSON-backed implementations (JsonGeneratorImpl) could have this method -- but it is not necessarily even needed (existing code doesn't use this).

@JooHyukKim JooHyukKim closed this Jan 22, 2024
@JooHyukKim
Copy link
Member Author

As per my note on the other PR: let's not add this -- there is a reason this method is not included in JsonGenerator. Naming here is bit unfortunate, but basically:

Reasonable. CLosed this accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants