-
-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make helper methods of WriterBasedJsonGenerator
non-final to allow overriding
#1305
Conversation
The protected method removes the final to allow users to rewrite the method and implement their own logic
src/main/java/com/fasterxml/jackson/core/json/WriterBasedJsonGenerator.java
Outdated
Show resolved
Hide resolved
src/main/java/com/fasterxml/jackson/core/json/WriterBasedJsonGenerator.java
Outdated
Show resolved
Hide resolved
I am ok with targeted removal of |
Aside from requested change wrt static fields, one thing I'd need before merging is CLA (unless already received one), from: https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf The usual way is to print it, fill & sign, scan/photo, email to |
Okay, I want to add some of my own logical operations before writing to outBuffer, but I couldn't find the provided entry, so I saw the WriterBasedJsonGenerator class. However, some of the protected methods were declared final, which confused me. Is there any other better way for me to operate, similar to an AOP |
@zhangOranges One thing that might work
which could intercept calls. It depends on kinds of changes you need to make. |
{ |
I want to add some other things before writing the correct JSON key value |
Is there any other simple signature method? I currently don't have a printer |
It would be possible to override |
What some contributors have done is to use an app that takes PDF, allows adding text to fill in the fields (add text in approximate location). That works for me. |
Which email to send after signing |
WriteFieldName will add a comma to the end of the previous execution, so this method is not feasible |
I mentioned this earlier; "cla@fasterxml.com" |
ok |
has been sent |
Ok received the first CLA and while it's almost good asked for minor edit (so there's name and github id both). |
has been sent |
CLA received. |
WriterBasedJsonGenerator
non-final to allow overriding
The protected method removes the final to allow users to rewrite the method and implement their own logic