Added writeString(Reader, int) method to JsonGenerator as requested i… #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think it works... which is also why unit test(s) would absolutely be required here. :) |
cowtowncoder
reviewed
Feb 9, 2017
| */ | ||
| public void writeString(Reader reader, int charLength) throws IOException { | ||
| if (reader == null) { | ||
| return; |
There was a problem hiding this comment.
This should be an error probably ,not just bailing out.
cowtowncoder
reviewed
Feb 9, 2017
| } | ||
|
|
||
| if (charLength == -1) { | ||
| while (reader.read() != -1) ; |
There was a problem hiding this comment.
Uh, what? If not known, quietly swallow content?!?!? And do that as inefficiently as possible, char by char, instead of skipping?
cowtowncoder
reviewed
Feb 9, 2017
| } else { | ||
| int readChars = reader.read(new char[charLength]); | ||
|
|
||
| if (readChars < charLength) { |
There was a problem hiding this comment.
,... and readers are entirely within their rights to return less.
|
Uh no. This makes no sense as implementation, no unit test. What the hell. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #17 issue.
Well, at least I think so. :)