New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uptake latest FastDoubleParser code #837
Conversation
263326c
to
cdb7b4d
Compare
Ok, quite a PR! I'll merge it but may need help with |
@pjfanning Ok, unfortunately merge from 2.15 to I also wonder if there's any way we could modularize things somehow, to isolate FastDoubleParser package. Not sure how that'd work; multi-Maven-module set up with shading might work but... that sounds complex and clunky. |
Unfortunately, FastDoubleParser is not released as a jar (at least not recently). I can do a new PR for the master branch tomorrow. |
Thank you @pjfanning. One thing that might help with merging would also be staging changes (in case of renames f.ex) but that might not be an option when just syncing with changes from FDP. |
Latest code from https://github.com/wrandelshofer/FastDoubleParser
Has added BigDecimal parsing support that may be useful - but not yet wired in - I can do that in a later PR that optionally allows this parser code instead of BigDecimalUtil