Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uptake latest FastDoubleParser code #837

Merged
merged 7 commits into from Nov 16, 2022

Conversation

pjfanning
Copy link
Member

Latest code from https://github.com/wrandelshofer/FastDoubleParser

Has added BigDecimal parsing support that may be useful - but not yet wired in - I can do that in a later PR that optionally allows this parser code instead of BigDecimalUtil

@pjfanning pjfanning marked this pull request as draft November 11, 2022 13:23
@pjfanning pjfanning marked this pull request as ready for review November 11, 2022 14:02
@cowtowncoder
Copy link
Member

Ok, quite a PR! I'll merge it but may need help with master (3.0) merging, will let you know if so.

@cowtowncoder cowtowncoder merged commit 7fa3770 into FasterXML:2.15 Nov 16, 2022
@cowtowncoder
Copy link
Member

@pjfanning Ok, unfortunately merge from 2.15 to master is... messy. I think I'll need your help with that again.

I also wonder if there's any way we could modularize things somehow, to isolate FastDoubleParser package. Not sure how that'd work; multi-Maven-module set up with shading might work but... that sounds complex and clunky.
And I guess "hiding" packages under unchanging Maven package within project would also defeat the benefits of namespacing -- like, f.ex if we (hypothetically) decided to use "local.foo." as package for 2.x and 3.x we'd have collision again (at least pre-Module system).
If FDP existed in published jar we could use Shade plug-in to add it but I don't know if that exists either?
If so 2.x and 3.x could re-package it to different places.

@pjfanning
Copy link
Member Author

Unfortunately, FastDoubleParser is not released as a jar (at least not recently). I can do a new PR for the master branch tomorrow.

@pjfanning pjfanning deleted the double-parser branch November 16, 2022 01:50
@cowtowncoder
Copy link
Member

Thank you @pjfanning.

One thing that might help with merging would also be staging changes (in case of renames f.ex) but that might not be an option when just syncing with changes from FDP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants