Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "activateDefaultTyping" over "enableDefaultTyping" in 2.10 with new methods #2428

Closed
cowtowncoder opened this issue Aug 20, 2019 · 0 comments

Comments

@cowtowncoder
Copy link
Member

As one additional change beyond #2195, let's make sure that naming of methods that turn on (or off) default typing differs from existing methods: although consistency in naming is usually a good thing, in this case it makes sense to "deprecate" old names so that simple code search can find all risky instances of old methods, without having to check argument counts and types.

So: existing methods will remain (but be deprecated, warnings added) as:

  • enableDefaultTyping() to turn functionality on (with specific constraints)
  • disableDefaultTyping() to turn functionality off.
  • setDefaultTyping() to enable with fully custom handler

but replacement methods will named differently:

  • activeDefaultTyping() to turn functionality on WITH ADDITIONAL VALIDATOR
  • deactiveDefaultTyping() to turn functionality off.
  • customDefaultTyping() for turning off with fully custom handling (with warnings to indicate that use requires understanding of validation aspects).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant