-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PersistentCollectionSerializer.java #173
Conversation
fix REPLACE_PERSISTENT_COLLECTIONS in EAGER FasterXML#146
@cowtowncoder I am not a lawyer - but this PR seems to be a direct copy of #146 (issue #140) so this PR should probably not be considered the original work of @Taha-Di-Nero - this makes it problematic to merge this PR since the copyright on the code here is at least debatable. |
We'd also need this for all backends, not just H5 and H6. As to contribution, this is not a super sizable change so one could argue that one could come up with this on their own (there aren't that many ways to do it). Let's hope author of #146 can contribute it, if so this could be just addition to H6. |
@pjfanning @cowtowncoder Yes this is applying the same patch done in #146 but for hibernate 6, the author of #146 is my colleague and I asked him to do what @cowtowncoder requested but he doesn't want to do it. |
@Taha-Di-Nero Ok as long as author is fine with your contributing the code (you have discussed it), and you are ok sending CLA (which just attests that you think you can contribute the code), I think we can merge it. But one thing I realize now is that there is no unit test to verify this fix works. I guess you are using a fork so I don't doubt it doesn't, but if there was one way to test it that'd obviously be great. |
@cowtowncoder contributor-agreement.pdf |
Excellent, thank you @Taha-Di-Nero ! Ok, aside from tests (it's ok since you have tested this), could I ask same changes for If you don't have time I can do it later on but just in case. I hope to merge this later today -- thank you once again for contributing this. It will make it in 2.16.0. |
fix REPLACE_PERSISTENT_COLLECTIONS in EAGER #146