This repository has been archived by the owner on Nov 7, 2019. It is now read-only.
Handle JSON serialized Dates from JavaScript in LocalDateTimeDeserializer #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping? |
|
Looks good to me, thank you for contributing this (and pinging me -- I had seen it forgot to follow up). The only thing I need before merging it (unless I have asked for this before) is filled Contributor License Agreement (CLA) from: https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf which we need to get in file before the first merge (but only then; these work for all future contributions). Thank you once again. |
|
My turn to apologise for not responding quickly :). I sent the filled agreement! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More or less the same changes that #56 provided for the LocalDateDeserializer. See @sandermak's description in that PR #56, this PR adds support for dates originating from JS to LocalDateTimeDeserializer.