Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create jakarta artifact replacing javax.json with jakarta.json #11

Merged
merged 1 commit into from
Mar 2, 2021

Conversation

fwiesweg
Copy link

Fixes #6.

This is an alternative solution to the problem, using postprocessing of the class files using the maven-shade-plugin as applied by jackson-jaxrs-providers.

@cowtowncoder
Copy link
Member

Thank you! That looks good, and I'd be happy to merge it.

Before merging there is just one process thing: I'd need a CLA (unless I have gotten one earlier at some point -- only needs to be done once before the first merged PR).
CLA doc is here:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

and the usual mechanism is to print it, fill & sign, scan/photo, email to info fasterxml dot com.
Once I get it I'll store it and merge this PR.

Looking forward to merging!

@cowtowncoder cowtowncoder merged commit 1b26670 into FasterXML:master Mar 2, 2021
@cowtowncoder cowtowncoder added this to the 2.12.2 milestone Mar 2, 2021
@cowtowncoder
Copy link
Member

CLA received, merged. Will backport in 2.12 branch for 2.12.2.

@cowtowncoder
Copy link
Member

Alas, need to revert; 2.12.2 release broke due to... something.

@cowtowncoder cowtowncoder removed this from the 2.12.2 milestone Mar 5, 2021
@fwiesweg
Copy link
Author

fwiesweg commented Mar 5, 2021

Sure, I'm not in a hurry to get this out of the door. Anything I can do?

@cowtowncoder
Copy link
Member

@fwiesweg I think we are ok -- I ended up instead merging #10 to get the similar end result, but instead of using classifier, there's separate artifact (jackson-datatype-jakarta-jsonp). There's now some code duplication but number of classes is small so I am not very worried; and for 3.0 at least we may want to drop jsr-353 module (TBD what to do with 2.x, at least after 2.13).

Still need to figure out what's wrong with classifier approach as that is needed for JAX-RS, but in short term I think this repo will get by without solving that. I do hope 2.12.2/jackson-datatype-jsr353 artifact can be corrected by sonatype admins tho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add jakarta classifier version of jackson-datatype-jsr353 to work with new Jakarta-based JSON-P
2 participants