Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate key detection does not work for (simple) Trees #51

Closed
cowtowncoder opened this issue Apr 17, 2017 · 1 comment
Closed

Duplicate key detection does not work for (simple) Trees #51

cowtowncoder opened this issue Apr 17, 2017 · 1 comment
Labels
2.17
Milestone
2.17.0

Comments

@cowtowncoder
Copy link
Member

cowtowncoder commented Apr 17, 2017 •
edited

(note: continuation from #50)

So: enabling JSON.Feature.FAIL_ON_DUPLICATE_MAP_KEYS does not make tree builder enable duplicate checking.
@cowtowncoder cowtowncoder removed the 2.11 label Apr 24, 2020
@cowtowncoder
Copy link
Member Author

Alas, this can not be currently implemented because JacksonJrsTreeCodec does not have access to configuration information -- its readTree() method is only passed JsonParser but nothing else.

Not sure what would be the best way to tackle this: one option would be to require codec to be configured separately, but that does not seem optimal.

cowtowncoder added a commit that referenced this issue Apr 24, 2020
@cowtowncoder
Add failign test for #51, just in case
f6e9813
@cowtowncoder cowtowncoder added 2.14 and removed 2.13 labels Jan 10, 2022
@Shounaks Shounaks mentioned this issue Feb 28, 2024
Merged
@cowtowncoder cowtowncoder mentioned this issue Mar 8, 2024
Closed
@cowtowncoder cowtowncoder added 2.17 and removed 2.14 labels Mar 11, 2024
@cowtowncoder cowtowncoder added this to the 2.17.0 milestone Mar 11, 2024
@cowtowncoder cowtowncoder mentioned this issue Mar 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.17
Projects
None yet
Milestone
2.17.0
Development

No branches or pull requests
1 participant
@cowtowncoder