Privatize KotlinFeature's enabledByDefault

Suggested by efenderbosch@github & TWiStErRob@github #477 (comment)
FasterXML · Jul 20, 2021 · 0793bbb · 0793bbb
1 parent 414327f
commit 0793bbb
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/src/main/kotlin/com/fasterxml/jackson/module/kotlin/KotlinFeature.kt b/src/main/kotlin/com/fasterxml/jackson/module/kotlin/KotlinFeature.kt
@@ -6,7 +6,7 @@ import kotlin.math.pow
 /**
  * @see KotlinModule.Builder
  */
-enum class KotlinFeature(val enabledByDefault: Boolean) {
+enum class KotlinFeature(private val enabledByDefault: Boolean) {
     /**
      * This feature represents whether to deserialize `null` values for collection properties as empty collections.
      */
@@ -45,4 +45,11 @@ enum class KotlinFeature(val enabledByDefault: Boolean) {
     StrictNullChecks(enabledByDefault = false);
 
     internal val bitSet: BitSet = 2.0.pow(ordinal).toInt().toBitSet()
+
+    companion object {
+        internal val defaults
+            get() = 0.toBitSet().apply {
+                values().filter { it.enabledByDefault }.forEach { or(it.bitSet) }
+            }
+    }
 }
diff --git a/src/main/kotlin/com/fasterxml/jackson/module/kotlin/KotlinModule.kt b/src/main/kotlin/com/fasterxml/jackson/module/kotlin/KotlinModule.kt
@@ -139,9 +139,7 @@ class KotlinModule @Deprecated(
         var reflectionCacheSize: Int = 512
             private set
 
-        private val bitSet: BitSet = 0.toBitSet().apply {
-            KotlinFeature.values().filter { it.enabledByDefault }.forEach { or(it.bitSet) }
-        }
+        private val bitSet: BitSet = KotlinFeature.defaults
 
         fun withReflectionCacheSize(reflectionCacheSize: Int): Builder = apply {
             this.reflectionCacheSize = reflectionCacheSize