Discover Subclasses of a sealed class automatically #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
making it possible to omit the @JsonSubTypes annotation.
|
You are absolutely correct wrt caching: Code looks pretty clean to me (although I'd defer to @apatrida or others with kotlin-fu). The only minor question I have is that of whether it is ever the case that someone might NOT want this auto-discovery. |
|
Ok, I assume this is fine. I am not sure if there are any problems if there are further sub-classes (sounds like sub-classes may have further sub-classes), but assume there are no issues. |
Nthalk
added a commit
to Nthalk/typescript-generator
that referenced
this pull request
Jan 17, 2023
Java language level 17 and above supports isSealed on member types. This uses the proposal of FasterXML/jackson-module-kotlin#239 and the general solution of FasterXML/jackson-module-kotlin#240 to import subtypes of a sealed object or interface that are annotated with `@JsonTypeName` and assignable to the container class or interface to create a much less verbose method of generating tagged unions.
Nthalk
added a commit
to Nthalk/typescript-generator
that referenced
this pull request
Jan 17, 2023
This uses the proposal of FasterXML/jackson-module-kotlin#239 and the general solution of FasterXML/jackson-module-kotlin#240 to import subtypes of a sealed object or interface that are annotated with `@JsonTypeName` and assignable to the container class or interface to create a much less verbose method of generating tagged unions. Sealed types are supported in kotlin 1.6+ and Java 17+, however, we don't really need the sealed functionality, as we are an offline, one-shot generator, this may work to generate the correct type mappings, but fail to parse on the runtime object mapper side unless the user is using the supported kotlin and java versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed in #239, this implements automatic detection of sealed class subtypes.
I don't know how important it would be to cache this result. As far as I understand it, the ObjectMapper instance will cache it internally, but someone with more insight into Jackson's internal might need to comment.