Any fields present in the constructor do not have to be null #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NOT need to be nullable, flushed out second half of test of class with two constructors, updated docs
|
Don' know how I didn't see pull requests for this long, will check and integrate, thanks |
|
You could also check and document using to: |
|
@rocketraman that isn't correct, the property is never initialized at all, so @jkschneider it doesn't have to be nullable, it just has to have a default value whatever it is because it is never set by the deserialization. |
apatrida
added a commit
that referenced
this pull request
Jun 4, 2016
Pull request #5 Kotlin 1.0.2 Code cleanup
|
This has been merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core code unchanged, but added tests to prove this out. Also added more to the test of a class that has a primary and secondary constructor to prove that indeed both could be used by to deserialize.
Updated the docs to strike comment about the requirement for nullability of fields not present in the constructor.