Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Regression) Serialization of a class containing Option[JsonNode] fails #103

Closed
ittaiz opened this issue Oct 9, 2013 · 6 comments
Closed

Comments

@ittaiz
Copy link

ittaiz commented Oct 9, 2013

Between 2.2.1 and 2.2.2 the OptionSerializer was made " with ContextualSerializer" due to #81
This somehow caused serialization of classes containing an Option[JsonNode] to fail.
This gist (https://gist.github.com/ittaiz/6903795) contains a failing test.
If you could point me at the right direction I'd be more than happy to try and contribue a pull request

@christophercurrie
Copy link
Member

Thanks for the report. I'll look into this as soon as I can.

@ittaiz
Copy link
Author

ittaiz commented Oct 9, 2013

Glad to.
As I said if, once you get around to it, you can point me in the right
direction I'd be happy to try and submit a pull request.

בתאריך יום רביעי, 9 באוקטובר 2013, Christopher Currie כתב:

Thanks for the report. I'll look into this as soon as I can.


Reply to this email directly or view it on GitHubhttps://github.com//issues/103#issuecomment-26007636
.

@ittaiz
Copy link
Author

ittaiz commented Oct 20, 2013

Thanks!
Any chance of a 2.2.4?
We recently upgraded from 2.1 to 2.2.3 and it was a painful upgrade due to this bug and others and upgrading a minor version (which in reality is more like a major version) soon is something we'd like to avoid.

@christophercurrie
Copy link
Member

Right now at best this might be in a 2.2.3-1 (something I dislike doing, as end users seldom find those versions), as upstream Jackson doesn't currently have plans for 2.2.4. Either will likely wait until 2.3 is out the door, but I will try to lay the groundwork for it so that it can happen quickly thereafter.

@ittaiz
Copy link
Author

ittaiz commented Oct 20, 2013

A 2.2.3-1 would be very appreciated, thanks.

@christophercurrie
Copy link
Member

Version 2.3.0-rc1 has been released with this fix. It'd be a big help if you could try out the release candidate and let us know if you have any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants