Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add handling of JsonFormat.Feature.READ_DATE_TIMESTAMPS_AS_NANOSECONDS #277

Merged
merged 1 commit into from
Jun 19, 2023
Merged

add handling of JsonFormat.Feature.READ_DATE_TIMESTAMPS_AS_NANOSECONDS #277

merged 1 commit into from
Jun 19, 2023

Conversation

raman-babich
Copy link
Contributor

@raman-babich raman-babich commented Jun 16, 2023 •
edited

Fixes #272

@cowtowncoder
Copy link
Member

Thank you for submitting this, @raman-babich ! I hope to review that in near future, but I do have some backlog. Maybe others can give feedback in the meantime.

Also; unless we have CLA from you, before merging the first PR, we'd need it from here:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

(usual way being to print it, fill & sign, scan/photo, email to info at fasterxml dot com)

and once we have it (only needed once so if you have sent one before, just let us know) merging is possible.

Thank you once again & looking forward to getting this merged!

@raman-babich
Copy link
Contributor Author

What should I specify as a project name, jackson or jackson-module-java8?

@cowtowncoder
Copy link
Member

@raman-babich Sorry I missed this: feel free to just use "Jackson" (both work fwtw but generic is better)

@cowtowncoder cowtowncoder added the cla-needed PR looks good (although may also require code review), but CLA needed from submitter label Jun 19, 2023
@raman-babich
Copy link
Contributor Author

Have sent signed CLA.

@cowtowncoder cowtowncoder removed the cla-needed PR looks good (although may also require code review), but CLA needed from submitter label Jun 19, 2023
@cowtowncoder
Copy link
Member

CLA received.

@cowtowncoder cowtowncoder added this to the 2.16.0 milestone Jun 19, 2023
@cowtowncoder cowtowncoder merged commit b0da1e6 into FasterXML:2.16 Jun 19, 2023
4 checks passed
@cowtowncoder
Copy link
Member

Thank you @raman-babich !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cowtowncoder cowtowncoder cowtowncoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.16.0
Development

Successfully merging this pull request may close these issues.

JsonFormat.Feature.WRITE_DATE_TIMESTAMPS_AS_NANOSECONDS not respected when deserialising Instants
2 participants
@raman-babich @cowtowncoder