Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

Use InputHandler method of click handling instead of current one in SinglePlayerButton #26

Closed
Fastjur opened this issue Sep 12, 2016 · 3 comments
Assignees

Comments

@Fastjur
Copy link
Owner

Fastjur commented Sep 12, 2016

No description provided.

@Wolgo
Copy link
Collaborator

Wolgo commented Sep 12, 2016

SinglePlayerButton extends Button, the onclick of button is called by doUpdate() which already uses if(InputHandler.isLeftMouseButtonDown) . Is there something wrong with this?

@grappigegovert
Copy link
Collaborator

Looks okay to me, there only are some unnecessary debug messages left

@Fastjur
Copy link
Owner Author

Fastjur commented Sep 12, 2016

Hmm. It was my impression that SinglePlayerButton still used an old implementation because it spams the debug info. However the other button does to. This was probably some lag on my end when testing with other buttons. This does raise the question. Do we want the contains method to be spammed like this or should we prevent this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants