Fixing initialization process

FastyBird · Aug 23, 2021 · 2617915 · 2617915
1 parent f6428ad
commit 2617915
Showing 1 changed file with 12 additions and 6 deletions.
diff --git a/devices_module/models.py b/devices_module/models.py
@@ -957,10 +957,10 @@ class DevicesPropertiesRepository(PropertiesRepository):
         @orm.db_session
         def initialize(self) -> None:
             """Initialize repository by fetching entities from database"""
-            self._items = dict()
+            items: Dict[str, DevicePropertyItem] = dict()
 
             for entity in DevicePropertyEntity.select():
-                self._items[entity.property_id.__str__()] = DevicePropertyItem(
+                items[entity.property_id.__str__()] = DevicePropertyItem(
                     property_id=entity.property_id,
                     property_identifier=entity.identifier,
                     property_key=entity.key,
@@ -972,6 +972,8 @@ def initialize(self) -> None:
                     device_id=entity.device.device_id,
                 )
 
+            self._items = items
+
     class ChannelsPropertiesRepository(PropertiesRepository):
         """
         Channels properties repository
@@ -984,10 +986,10 @@ class ChannelsPropertiesRepository(PropertiesRepository):
         @orm.db_session
         def initialize(self) -> None:
             """Initialize repository by fetching entities from database"""
-            self._items = dict()
+            items: Dict[str, ChannelPropertyItem] = dict()
 
             for entity in ChannelPropertyEntity.select():
-                self._items[entity.property_id.__str__()] = ChannelPropertyItem(
+                items[entity.property_id.__str__()] = ChannelPropertyItem(
                     property_id=entity.property_id,
                     property_identifier=entity.identifier,
                     property_key=entity.key,
@@ -1000,6 +1002,8 @@ def initialize(self) -> None:
                     channel_id=entity.channel.channel_id,
                 )
 
+            self._items = items
+
     class ConnectorsRepository(ABC):
         """
         Connectors repository
@@ -1049,10 +1053,10 @@ def clear(self) -> None:
         @orm.db_session
         def initialize(self) -> None:
             """Initialize repository by fetching entities from database"""
-            self.__items = dict()
+            items: Dict[str, ConnectorItem] = dict()
 
             for entity in ConnectorEntity.select():
-                self.__items[entity.connector_id.__str__()] = ConnectorItem(
+                items[entity.connector_id.__str__()] = ConnectorItem(
                     connector_id=entity.connector_id,
                     connector_name=entity.name,
                     connector_key=entity.key,
@@ -1061,6 +1065,8 @@ def initialize(self) -> None:
                     connector_params=entity.params,
                 )
 
+            self.__items = items
+
         # -----------------------------------------------------------------------------
 
         def __iter__(self) -> "ConnectorsRepository":