[web-server-plugin][ws-server-plugin] Updating documentation (#250)

FastyBird · Feb 27, 2024 · db0574d · db0574d
1 parent ee830b9
commit db0574d
Show file tree

Hide file tree

Showing 9 changed files with 45 additions and 99 deletions.
diff --git a/src/Queries/Entities/FindChannelControls.php b/src/Queries/Entities/FindChannelControls.php
@@ -19,10 +19,8 @@
 use Doctrine\Common;
 use Doctrine\ORM;
 use FastyBird\Module\Devices\Entities;
-use FastyBird\Module\Devices\Exceptions;
 use IPub\DoctrineOrmQuery;
 use Ramsey\Uuid;
-use function in_array;
 
 /**
  * Find channel controls entities query
@@ -72,17 +70,13 @@ public function byChannelId(Uuid\UuidInterface $channelId): void
 		};
 	}
 
-	/**
-	 * @throws Exceptions\InvalidArgument
-	 */
-	public function sortBy(string $sortBy, string $sortDir = Common\Collections\Criteria::ASC): void
+	public function sortBy(
+		string $sortBy,
+		Common\Collections\Order $sortDir = Common\Collections\Order::Ascending,
+	): void
 	{
-		if (!in_array($sortDir, [Common\Collections\Criteria::ASC, Common\Collections\Criteria::DESC], true)) {
-			throw new Exceptions\InvalidArgument('Provided sortDir value is not valid.');
-		}
-
 		$this->filter[] = static function (ORM\QueryBuilder $qb) use ($sortBy, $sortDir): void {
-			$qb->addOrderBy($sortBy, $sortDir);
+			$qb->addOrderBy($sortBy, $sortDir->value);
 		};
 	}
 

diff --git a/src/Queries/Entities/FindChannelProperties.php b/src/Queries/Entities/FindChannelProperties.php
@@ -19,10 +19,8 @@
 use Doctrine\Common;
 use Doctrine\ORM;
 use FastyBird\Module\Devices\Entities;
-use FastyBird\Module\Devices\Exceptions;
 use IPub\DoctrineOrmQuery;
 use Ramsey\Uuid;
-use function in_array;
 
 /**
  * Find channel properties entities query
@@ -116,17 +114,13 @@ public function queryable(bool $state): void
 		};
 	}
 
-	/**
-	 * @throws Exceptions\InvalidArgument
-	 */
-	public function sortBy(string $sortBy, string $sortDir = Common\Collections\Criteria::ASC): void
+	public function sortBy(
+		string $sortBy,
+		Common\Collections\Order $sortDir = Common\Collections\Order::Ascending,
+	): void
 	{
-		if (!in_array($sortDir, [Common\Collections\Criteria::ASC, Common\Collections\Criteria::DESC], true)) {
-			throw new Exceptions\InvalidArgument('Provided sortDir value is not valid.');
-		}
-
 		$this->filter[] = static function (ORM\QueryBuilder $qb) use ($sortBy, $sortDir): void {
-			$qb->addOrderBy($sortBy, $sortDir);
+			$qb->addOrderBy($sortBy, $sortDir->value);
 		};
 	}
 

diff --git a/src/Queries/Entities/FindChannels.php b/src/Queries/Entities/FindChannels.php
@@ -19,10 +19,8 @@
 use Doctrine\Common;
 use Doctrine\ORM;
 use FastyBird\Module\Devices\Entities;
-use FastyBird\Module\Devices\Exceptions;
 use IPub\DoctrineOrmQuery;
 use Ramsey\Uuid;
-use function in_array;
 
 /**
  * Find device channels entities query
@@ -113,17 +111,13 @@ public function withSettableProperties(): void
 		};
 	}
 
-	/**
-	 * @throws Exceptions\InvalidArgument
-	 */
-	public function sortBy(string $sortBy, string $sortDir = Common\Collections\Criteria::ASC): void
+	public function sortBy(
+		string $sortBy,
+		Common\Collections\Order $sortDir = Common\Collections\Order::Ascending,
+	): void
 	{
-		if (!in_array($sortDir, [Common\Collections\Criteria::ASC, Common\Collections\Criteria::DESC], true)) {
-			throw new Exceptions\InvalidArgument('Provided sortDir value is not valid.');
-		}
-
 		$this->filter[] = static function (ORM\QueryBuilder $qb) use ($sortBy, $sortDir): void {
-			$qb->addOrderBy($sortBy, $sortDir);
+			$qb->addOrderBy($sortBy, $sortDir->value);
 		};
 	}
 

diff --git a/src/Queries/Entities/FindConnectorControls.php b/src/Queries/Entities/FindConnectorControls.php
@@ -19,10 +19,8 @@
 use Doctrine\Common;
 use Doctrine\ORM;
 use FastyBird\Module\Devices\Entities;
-use FastyBird\Module\Devices\Exceptions;
 use IPub\DoctrineOrmQuery;
 use Ramsey\Uuid;
-use function in_array;
 
 /**
  * Find connector properties entities query
@@ -72,17 +70,13 @@ public function byConnectorId(Uuid\UuidInterface $connectorId): void
 		};
 	}
 
-	/**
-	 * @throws Exceptions\InvalidArgument
-	 */
-	public function sortBy(string $sortBy, string $sortDir = Common\Collections\Criteria::ASC): void
+	public function sortBy(
+		string $sortBy,
+		Common\Collections\Order $sortDir = Common\Collections\Order::Ascending,
+	): void
 	{
-		if (!in_array($sortDir, [Common\Collections\Criteria::ASC, Common\Collections\Criteria::DESC], true)) {
-			throw new Exceptions\InvalidArgument('Provided sortDir value is not valid.');
-		}
-
 		$this->filter[] = static function (ORM\QueryBuilder $qb) use ($sortBy, $sortDir): void {
-			$qb->addOrderBy($sortBy, $sortDir);
+			$qb->addOrderBy($sortBy, $sortDir->value);
 		};
 	}
 

diff --git a/src/Queries/Entities/FindConnectorProperties.php b/src/Queries/Entities/FindConnectorProperties.php
@@ -19,10 +19,8 @@
 use Doctrine\Common;
 use Doctrine\ORM;
 use FastyBird\Module\Devices\Entities;
-use FastyBird\Module\Devices\Exceptions;
 use IPub\DoctrineOrmQuery;
 use Ramsey\Uuid;
-use function in_array;
 
 /**
  * Find connector properties entities query
@@ -101,17 +99,13 @@ public function queryable(bool $state): void
 		};
 	}
 
-	/**
-	 * @throws Exceptions\InvalidArgument
-	 */
-	public function sortBy(string $sortBy, string $sortDir = Common\Collections\Criteria::ASC): void
+	public function sortBy(
+		string $sortBy,
+		Common\Collections\Order $sortDir = Common\Collections\Order::Ascending,
+	): void
 	{
-		if (!in_array($sortDir, [Common\Collections\Criteria::ASC, Common\Collections\Criteria::DESC], true)) {
-			throw new Exceptions\InvalidArgument('Provided sortDir value is not valid.');
-		}
-
 		$this->filter[] = static function (ORM\QueryBuilder $qb) use ($sortBy, $sortDir): void {
-			$qb->addOrderBy($sortBy, $sortDir);
+			$qb->addOrderBy($sortBy, $sortDir->value);
 		};
 	}
 

diff --git a/src/Queries/Entities/FindConnectors.php b/src/Queries/Entities/FindConnectors.php
@@ -19,10 +19,8 @@
 use Doctrine\Common;
 use Doctrine\ORM;
 use FastyBird\Module\Devices\Entities;
-use FastyBird\Module\Devices\Exceptions;
 use IPub\DoctrineOrmQuery;
 use Ramsey\Uuid;
-use function in_array;
 
 /**
  * Find connectors entities query
@@ -57,17 +55,13 @@ public function byIdentifier(string $identifier): void
 		};
 	}
 
-	/**
-	 * @throws Exceptions\InvalidArgument
-	 */
-	public function sortBy(string $sortBy, string $sortDir = Common\Collections\Criteria::ASC): void
+	public function sortBy(
+		string $sortBy,
+		Common\Collections\Order $sortDir = Common\Collections\Order::Ascending,
+	): void
 	{
-		if (!in_array($sortDir, [Common\Collections\Criteria::ASC, Common\Collections\Criteria::DESC], true)) {
-			throw new Exceptions\InvalidArgument('Provided sortDir value is not valid.');
-		}
-
 		$this->filter[] = static function (ORM\QueryBuilder $qb) use ($sortBy, $sortDir): void {
-			$qb->addOrderBy($sortBy, $sortDir);
+			$qb->addOrderBy($sortBy, $sortDir->value);
 		};
 	}
 

diff --git a/src/Queries/Entities/FindDeviceControls.php b/src/Queries/Entities/FindDeviceControls.php
@@ -19,10 +19,8 @@
 use Doctrine\Common;
 use Doctrine\ORM;
 use FastyBird\Module\Devices\Entities;
-use FastyBird\Module\Devices\Exceptions;
 use IPub\DoctrineOrmQuery;
 use Ramsey\Uuid;
-use function in_array;
 
 /**
  * Find device controls entities query
@@ -72,17 +70,13 @@ public function byDeviceId(Uuid\UuidInterface $deviceId): void
 		};
 	}
 
-	/**
-	 * @throws Exceptions\InvalidArgument
-	 */
-	public function sortBy(string $sortBy, string $sortDir = Common\Collections\Criteria::ASC): void
+	public function sortBy(
+		string $sortBy,
+		Common\Collections\Order $sortDir = Common\Collections\Order::Ascending,
+	): void
 	{
-		if (!in_array($sortDir, [Common\Collections\Criteria::ASC, Common\Collections\Criteria::DESC], true)) {
-			throw new Exceptions\InvalidArgument('Provided sortDir value is not valid.');
-		}
-
 		$this->filter[] = static function (ORM\QueryBuilder $qb) use ($sortBy, $sortDir): void {
-			$qb->addOrderBy($sortBy, $sortDir);
+			$qb->addOrderBy($sortBy, $sortDir->value);
 		};
 	}
 

diff --git a/src/Queries/Entities/FindDeviceProperties.php b/src/Queries/Entities/FindDeviceProperties.php
@@ -19,10 +19,8 @@
 use Doctrine\Common;
 use Doctrine\ORM;
 use FastyBird\Module\Devices\Entities;
-use FastyBird\Module\Devices\Exceptions;
 use IPub\DoctrineOrmQuery;
 use Ramsey\Uuid;
-use function in_array;
 
 /**
  * Find device properties entities query
@@ -116,17 +114,13 @@ public function queryable(bool $state): void
 		};
 	}
 
-	/**
-	 * @throws Exceptions\InvalidArgument
-	 */
-	public function sortBy(string $sortBy, string $sortDir = Common\Collections\Criteria::ASC): void
+	public function sortBy(
+		string $sortBy,
+		Common\Collections\Order $sortDir = Common\Collections\Order::Ascending,
+	): void
 	{
-		if (!in_array($sortDir, [Common\Collections\Criteria::ASC, Common\Collections\Criteria::DESC], true)) {
-			throw new Exceptions\InvalidArgument('Provided sortDir value is not valid.');
-		}
-
 		$this->filter[] = static function (ORM\QueryBuilder $qb) use ($sortBy, $sortDir): void {
-			$qb->addOrderBy($sortBy, $sortDir);
+			$qb->addOrderBy($sortBy, $sortDir->value);
 		};
 	}
 

diff --git a/src/Queries/Entities/FindDevices.php b/src/Queries/Entities/FindDevices.php
@@ -19,10 +19,8 @@
 use Doctrine\Common;
 use Doctrine\ORM;
 use FastyBird\Module\Devices\Entities;
-use FastyBird\Module\Devices\Exceptions;
 use IPub\DoctrineOrmQuery;
 use Ramsey\Uuid;
-use function in_array;
 
 /**
  * Find devices entities query
@@ -144,17 +142,13 @@ public function withChannels(): void
 		};
 	}
 
-	/**
-	 * @throws Exceptions\InvalidArgument
-	 */
-	public function sortBy(string $sortBy, string $sortDir = Common\Collections\Criteria::ASC): void
+	public function sortBy(
+		string $sortBy,
+		Common\Collections\Order $sortDir = Common\Collections\Order::Ascending,
+	): void
 	{
-		if (!in_array($sortDir, [Common\Collections\Criteria::ASC, Common\Collections\Criteria::DESC], true)) {
-			throw new Exceptions\InvalidArgument('Provided sortDir value is not valid.');
-		}
-
 		$this->filter[] = static function (ORM\QueryBuilder $qb) use ($sortBy, $sortDir): void {
-			$qb->addOrderBy($sortBy, $sortDir);
+			$qb->addOrderBy($sortBy, $sortDir->value);
 		};
 	}